Skip to content

circular_linked_list.py#873

Closed
TheIncredibleHarsh wants to merge 3 commits into
TheAlgorithms:masterfrom
TheIncredibleHarsh:patch-1
Closed

circular_linked_list.py#873
TheIncredibleHarsh wants to merge 3 commits into
TheAlgorithms:masterfrom
TheIncredibleHarsh:patch-1

Conversation

@TheIncredibleHarsh

@TheIncredibleHarsh TheIncredibleHarsh commented Jun 4, 2019

Copy link
Copy Markdown

A circular linked list where the last node points to the first node. I don't know why it is missing and I think it should be here. Helps in traversing the list in circular order and we don't have to start traversing from head every time

Circular linked list is a linked list where last node is connected to the first node in the list. This can be used in traversals where we have to access a node before the current by access in a circular way.

@cclauss cclauss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename needs to end in “.py”

Also, please remove the semicolons (;) as this is Python, not JavaScript.

@TheIncredibleHarsh TheIncredibleHarsh changed the title circular_linked_list circular_linked_list.py Jun 4, 2019

@poyea poyea left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use 4 spaces to indent. Other than that LGTM. Thanks.

@TheIncredibleHarsh

Copy link
Copy Markdown
Author

Why is the LGTM check failing? It gives error on some other file, I'm sorry but I have never worked with it before

@cclauss

cclauss commented Jun 6, 2019

Copy link
Copy Markdown
Member

LGTM tests are failing because of the Python syntax error in #425

@TheIncredibleHarsh TheIncredibleHarsh deleted the patch-1 branch June 8, 2019 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants